Correct CurlLogger's URL to actual destination #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to take this with some tests / passing existing tests, please? |
|
@dekimsey Thank you for this change! Can you please rebase and get in the latest changes from main? |
|
Sorry for not seeing your request @dblock, it has been a busy year and I missed your request. I'm updating it now. I also fixed the tests to validate the change. |
dekimsey
force-pushed
the
patch-1
branch
3 times, most recently
from
2c6469a to
0dcd3e8
Compare
|
@VachaShah I believe this is complete now. Let me know what you think, thank you for pinging me on this! |
The CurlLogger hardcodes `http://localhost:9200`. This change instead uses the given configuration values. Signed-off-by: Daniel Kimsey <dkimsey@trustwave.com> Signed-off-by: Daniel Kimsey <dekimsey@protonmail.com>
dblock
approved these changes
Feb 7, 2023
|
Apologies for having missed this. I resolved the CHANGELOG conflict, let's merge this once CI passes. |
VachaShah
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The CurlLogger hardcodes
http://localhost:9200. This change instead uses the given configuration values.Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.